Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity tests for controleval.py #9918

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Dec 1, 2022

Description:

Adds sanity tests for the controleval.py

Rationale:

Catch bugs sooner.

@Mab879 Mab879 added the Infrastructure Our content build system label Dec 1, 2022
@Mab879 Mab879 added this to the 0.1.66 milestone Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

tests/CMakeLists.txt Outdated Show resolved Hide resolved
@jan-cerny
Copy link
Collaborator

I think we can do it for all 3 tests. That would make the tests faster.

@Mab879 Mab879 force-pushed the sanity_test_controleval branch from dcefa81 to 0e0d11f Compare December 2, 2022 19:34
@codeclimate
Copy link

codeclimate bot commented Dec 2, 2022

Code Climate has analyzed commit 0e0d11f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 48.8% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Dec 5, 2022
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the tests locally on a F37 laptop and I also have seen that they are executed in the upstream CI gating tests jobs eg. Fedora latast. Thanks for adding the test data!

@jan-cerny jan-cerny merged commit e7502af into ComplianceAsCode:master Dec 5, 2022
@Mab879 Mab879 deleted the sanity_test_controleval branch December 5, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants