Add Refchecker to Tests #9862
Merged
Add Refchecker to Tests #9862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mab879
added
Infrastructure
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
jan-cerny
requested changes
Nov 23, 2022
|
/packit build |
|
@jan-cerny , I saw you already reviewed this PR once. Are you comfortable to assign it to yourself? |
jan-cerny
requested changes
Dec 5, 2022
The script was not using the latest changes in the project and did not run.
Made refchecker use full paths for rule_dir_json, build config, and controls.
Before the first line was being overriden.
|
Code Climate has analyzed commit 9994c38 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 48.8% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
utils/refchecker.pyutils/refchecker.pychecks for RHEL7 and RHEL8 CIS profilesRationale:
utils/refchecker.pyusefulReview Hints:
linux_os/guide/system/software/integrity/crypto/configure_crypto_policy/rule.yml, and it should make the tests fail.