Formatting and bug fixes in utils/import_srg_spreadsheet.py

[Mab879]

Description:

• Replace hard-coded RHEL 9
• PEP8 Improvements

Rationale:

• Fixes issues that may come up later

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment

Oracle Linux 8 Environment

[jan-cerny]

@Mab879 Codeclimate wants you to reduce count of parameters of the update_row function

[Mab879]

@Mab879 Codeclimate wants you to reduce count of parameters of the update_row function

I will take a look and see how easy that will be.

[codeclimate]

Code Climate has analyzed commit bbd3092 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 47.1% (-0.1% change).

View more on Code Climate.

[jan-cerny]

@Mab879 now it's better

But what about the text where they use "RHEL9". without a space between RHEL and 9? We currently replace RHEL 9 with space in between but for example in security_patches_up_to_date they have

Verify RHEL9 security patches and updates are installed and up to date.    Updates are required to be applied with a frequency determined by organizational policy.

and creates a diff where {{{ full_name }}} is changed to RHEL9, which is a change that we don't want.

[Mab879]

@Mab879 now it's better

But what about the text where they use "RHEL9". without a space between RHEL and 9? We currently replace RHEL 9 with space in between but for example in security_patches_up_to_date they have

Verify RHEL9 security patches and updates are installed and up to date.    Updates are required to be applied with a frequency determined by organizational policy.

and creates a diff where {{{ full_name }}} is changed to RHEL9, which is a change that we don't want.

The latest update should fix that. This update also fixes the issue where the last line gets duplicated.

[jan-cerny]

I have run the script on the latest submission spreadsheet and current export from upstream and the diff of produced changes looks sensible and manageable.