Add test scenarios for rsyslog_remote_tls #4788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule uses a complex regular expression so it might be beneficial to cover the rule by few test scenarios.
jan-cerny
force-pushed
the
test_rsyslog_remote_tls
branch
from
1b36259 to
d3f1765
Compare
|
I have rebased it on master and also moved it to the appropriate directory. |
|
Do we need that |
|
@matejak That's needed to use the test scenarios within SSGTS to test the specific rule. |
When the profile keyword isn't specified in the header the test harness will use the virtual (all) profile.
|
@matejak I have removed profile IDs from the scenarios headers. |
|
Those tests are valid and work as expected. Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule uses a complex regular expression so it might be beneficial to cover the rule by few test scenarios.