Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial C2S Docker Profile #2422

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

redhatrises
Copy link
Contributor

Description:

  • Add initial C2S Docker Profile

Rationale:

  • Currently, there is no security profile for hardening docker.

@redhatrises redhatrises added the enhancement General enhancements to the project. label Oct 18, 2017
@redhatrises redhatrises added this to the 0.1.36 milestone Oct 18, 2017
@mpreisler
Copy link
Member

As it is this profile brings no value to users, I propose we implement at least some of the rules before we merge it.

@redhatrises
Copy link
Contributor Author

That's correct. Would like to get this in so people can start helping contributing towards it.

@mpreisler
Copy link
Member

Hmm. Could we perhaps start a branch that we will merge after the profiles have rules in them? We have an SSG release scheduled for end of the month, I don't want it to contain empty profiles.

@redhatrises
Copy link
Contributor Author

We have an SSG release scheduled for end of the month, I don't want it to contain empty profiles.

@mpreisler I selected at least one rule; otherwise, it would not have built. ;-P

@jan-cerny
Copy link
Collaborator

We already started a Docker profile for RHEL7. It's here https://github.com/OpenSCAP/scap-security-guide/blob/master/rhel7/profiles/docker-host.xml . The profile was also meant to follow the CIS Docker Community Edition Benchmark. I remember I studied the document that time.

However soon we didn't see a value in implementing a profile for Docker. What has changed? And why to have 2 profiles that are going to implement the same baseline?

@redhatrises
Copy link
Contributor Author

However soon we didn't see a value in implementing a profile for Docker. What has changed? And why to have 2 profiles that are going to implement the same baseline?

Not sure where this confusion is coming from here, but it is valuable for implementing a Docker profile.
I thought that the docker-host profile was some sort of standard Docker profile not based on any standards body (CIS) but just what we thought should be in it. Anything CIS based should be standardized to C2S-something as was already done with the existing C2S profile. I can remove one over the other unless we should have a standard docker profile like we do with the RHEL profiles which I would say keep docker-host profile for that.

@mpreisler
Copy link
Member

However soon we didn't see a value in implementing a profile for Docker. What has changed? And why to have 2 profiles that are going to implement the same baseline?

AFAIK we definitely saw value in it, we just prioritized content for containers and container images over content for docker host. There is value in docker host content for sure.

@redhatrises redhatrises modified the milestones: 0.1.36, 0.1.37 Oct 30, 2017
@yuumasato yuumasato modified the milestones: 0.1.37, 0.1.38 Jan 3, 2018
@yuumasato
Copy link
Member

I think we can merge and introduce this Profile to SSG.
And docker-host can be the Profile for standard checks, not sure if there would be much difference between Profiles.

@yuumasato
Copy link
Member

Merging, let the Profile grow and bloom!

@yuumasato yuumasato self-assigned this Mar 2, 2018
@yuumasato yuumasato merged commit 09cc61b into ComplianceAsCode:master Mar 2, 2018
@redhatrises redhatrises deleted the add_c2_docker branch March 2, 2018 13:58
@mpreisler
Copy link
Member

As it is this profile brings no value to users, I propose we implement at least some of the rules before we merge it.

Hmm. Could we perhaps start a branch that we will merge after the profiles have rules in them? We have an SSG release scheduled for end of the month, I don't want it to contain empty profiles.

I will reiterate that IMO this shouldn't have been merged. There is nothing in this profile, no value for users. Now it's in a release and will show up in installers, SCAP Workbench, guides, ...

CC @yuumasato @redhatrises

@yuumasato
Copy link
Member

@mpreisler Sorry for overlooking your review. With #2422 (comment) I thought your comment was addressed. Maybe it was a joke and I didn't get it.

I get your point. This Profile may be extreme example, with just one rule selected. But Profiles like ANSSI or HIPAA were also in very initial state. (though, thanks to #2650, HIPAA has much more content).
Besides number of selected rules, what is the difference between them?
Maybe expectation that there will be content for C2S is lower?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancements to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants