Update logind_session_timeout/not_configured.fail to handle if the systemd config is not there
#12884
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stemd config is not there
Mab879
added
Test Suite
Mab879
changed the title
logind_session_timeout/not_configured.fail to handle if the systemd config is not therelogind_session_timeout/not_configured.fail to handle if the systemd config is not there
|
Code Climate has analyzed commit d8e527a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
This change has fixed the not_configure.fail.sh scenario for me:
jcerny@fedora:~/work/git/scap-security-guide (pr/12884)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel10 logind_session_timeout
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-01-23-1017/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_logind_session_timeout
INFO - Script correct.pass.sh using profile (all) OK
INFO - Script correct_not_directly_after_section.pass.sh using profile (all) OK
INFO - Script correct_value_no_section.fail.sh using profile (all) OK
INFO - Script correct_value_wrong_section.fail.sh using profile (all) OK
INFO - Script file_missing.fail.sh using profile (all) OK
INFO - Script incorrect.fail.sh using profile (all) OK
INFO - Script not_configured.fail.sh using profile (all) OK
jcerny@fedora:~/work/git/scap-security-guide (pr/12884)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel10 --remediate-using ansible logind_session_timeout
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-01-23-1019/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_logind_session_timeout
INFO - Script correct.pass.sh using profile (all) OK
INFO - Script correct_not_directly_after_section.pass.sh using profile (all) OK
INFO - Script correct_value_no_section.fail.sh using profile (all) OK
INFO - Script correct_value_wrong_section.fail.sh using profile (all) OK
INFO - Script file_missing.fail.sh using profile (all) OK
INFO - Script incorrect.fail.sh using profile (all) OK
INFO - Script not_configured.fail.sh using profile (all) OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update
logind_session_timeout/not_configured.failto handle if the systemd config is not there.Rationale:
Fixes #12876