-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional work on the almalinux9 product #12883
base: master
Are you sure you want to change the base?
Conversation
Hi @sej7278. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Any idea how to fix this, I think we saw it in the initial new product PR too, one of the RHEL profiles has a test for suse gpgkeys which seems odd, but it doesn't fall for suse, but does for almalinux: The ctest's pass locally so I'm not sure how to reproduce. When I'm back behind a computer I'll dig out the profile and maybe remove the almalinux gpgkey reference, but not sure how to retest without committing it to this PR. This was the previous discussion of the issue: |
@@ -1246,6 +1246,7 @@ controls: | |||
- ensure_gpgcheck_local_packages | |||
- ensure_redhat_gpgkey_installed | |||
- ensure_oracle_gpgkey_installed | |||
- ensure_almalinux_gpgkey_installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to make sure that the rule ensure_almalinux_gpgkey_installed
doesn't get into content for other products than Alma. You will need to explicitly remove it from all profiles that use the anssi
control file.
Add
- '!ensure_almalinux_gpgkey_installed'
to selections:
in all .profile
files listed by git grep -l anssi: *.profile
.
We already do a similar thing for the ensure_oracle_gpgkey_installed
, for example:
- '!ensure_oracle_gpgkey_installed' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I added commit 5d7d0fe to address this for anssi and a couple of other profiles where i missed it.
137fe1f
to
5d7d0fe
Compare
Code Climate has analyzed commit 5d43270 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
Description:
More content for the almalinux9 product.
Added
multi_platform_almalinux
to various tests and remediation scripts where applicable - didn't just blindly usesed
, hence why its taking a while!I've still got about 300 files in linux_os/guide/ to go through before I even start working on the STIG or other profiles like ANSSI.
Verified and added the
pkg_release
andpkg_version
.