Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dpkg package applicability check in bash #12873

Merged

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Jan 22, 2025

Description:

  • Fix dpkg package applicability check in bash

Rationale:

  • The applicability check was matching packages with installed and not-installed status.

The applicability check was matching packages
with `installed` and `not-installed` status.
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 22, 2025
Copy link

openshift-ci bot commented Jan 22, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codeclimate bot commented Jan 22, 2025

Code Climate has analyzed commit 2207ea4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@dodys dodys self-assigned this Jan 23, 2025
@dodys dodys added the Bash Bash remediation update. label Jan 23, 2025
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys added Debian Debian product related. Ubuntu Ubuntu product related. labels Jan 23, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 23, 2025
@dodys dodys merged commit ccbc650 into ComplianceAsCode:master Jan 23, 2025
98 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. Debian Debian product related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants