Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename OVAL tests and objects to fix name conflict #12869

Merged

Conversation

vojtapolasek
Copy link
Collaborator

Description:

rename objects and tests in accounts_password_pam_pwhistory_remember and accounts_password_pam_pwhistory_enforce_root OVAL checks

Rationale:

  • the situation prevented the master branch from being built

Review Hints:

  • build and run ctest

@vojtapolasek vojtapolasek added the bugfix Fixes to reported bugs. label Jan 22, 2025
@vojtapolasek vojtapolasek added this to the 0.1.76 milestone Jan 22, 2025
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
OVAL for rule 'xccdf_org.ssgproject.content_rule_accounts_password_pam_pwhistory_enforce_root' differs.
--- oval:ssg-accounts_password_pam_pwhistory_enforce_root:def:1
+++ oval:ssg-accounts_password_pam_pwhistory_enforce_root:def:1
@@ -1,3 +1,3 @@
 criteria AND
-criterion oval:ssg-test_accounts_password_pam_pwhistory_enabled:tst:1
+criterion oval:ssg-test_accounts_password_pam_pwhistory_enforce_root_enabled:tst:1
 criterion oval:ssg-test_accounts_password_pam_pwhistory_enforce_for_root_parameter:tst:1

OVAL for rule 'xccdf_org.ssgproject.content_rule_accounts_password_pam_pwhistory_remember' differs.
--- oval:ssg-accounts_password_pam_pwhistory_remember:def:1
+++ oval:ssg-accounts_password_pam_pwhistory_remember:def:1
@@ -1,3 +1,3 @@
 criteria AND
-criterion oval:ssg-test_accounts_password_pam_pwhistory_enabled:tst:1
+criterion oval:ssg-test_accounts_password_pam_pwhistory_remember_enabled:tst:1
 criterion oval:ssg-test_accounts_password_pam_pwhistory_remember_parameter:tst:1

@jan-cerny jan-cerny self-assigned this Jan 22, 2025
Copy link

codeclimate bot commented Jan 22, 2025

Code Climate has analyzed commit 5774de8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9%.

View more on Code Climate.

@jan-cerny jan-cerny merged commit 12279d1 into ComplianceAsCode:master Jan 22, 2025
102 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants