Select enable_dracut_fips_module in RHEL 9 ISM_O profile #12859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As RHEL 9 ISM_O profile enables FIPS mode (selects rules `enable_fips_mode` and `configure_crypto_policy` with `var_system_crypto_policy=fips`) it also needs to select the rule `enable_dracut_fips_module`. This issue was not discovered before because on normal systems the `fips-mode-setup` (called in `enable_fips_mode` rule remediation) ensures the installation of the FIPS dracut module. But in RHEL Image Mode the `fips-mode-setup` is not used and so the FIPS dracut module needs to be enabled by remediation of the `enable_dracut_fips_module` rule.
|
Code Climate has analyzed commit cf56fe4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As RHEL 9 ISM_O profile enables FIPS mode (selects rules
enable_fips_modeandconfigure_crypto_policywithvar_system_crypto_policy=fips) it also needs to select the ruleenable_dracut_fips_module.This issue was not discovered before because on normal systems the
fips-mode-setup(called inenable_fips_moderule remediation) ensures the installation of the FIPS dracut module. But in RHEL Image Mode thefips-mode-setupis not used and so the FIPS dracut module needs to be enabled by remediation of theenable_dracut_fips_modulerule.