Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rule logging_services_active #12857

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Jan 20, 2025

Description:

  • Checks that one of rsyslog/systemd-journald is active.
  • Add rule to Ubuntu 24.04 CIS controls
  • Fix metadata in rule firewall_single_service_active

Rationale:

  • Satisfies Ubuntu 24.04 CIS control 6.1.1.4

@mpurg mpurg requested a review from a team as a code owner January 20, 2025 11:29
Copy link

openshift-ci bot commented Jan 20, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 20, 2025
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2404 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys self-assigned this Jan 20, 2025
@dodys dodys added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Jan 20, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 20, 2025
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpurg could you take a look at the failed tests?

@mpurg mpurg force-pushed the ubuntu2404_cis_6.1.1.4 branch 2 times, most recently from 5ade881 to e43b83a Compare January 22, 2025 10:00
@mpurg
Copy link
Contributor Author

mpurg commented Jan 22, 2025

Rebased and added cosmetic fix to tests.

Automatus fails are due to systemd not existing in container, same issue as #12511
Works on KVM:

INFO - xccdf_org.ssgproject.content_rule_firewall_single_service_active
INFO - Script single.pass.sh using profile (all) OK
INFO - Script none.fail.sh using profile (all) OK
INFO - Script multiple.fail.sh using profile (all) OK
INFO - xccdf_org.ssgproject.content_rule_logging_services_active
INFO - Script none.fail.sh using profile (all) OK
INFO - Script multiple.pass.sh using profile (all) OK
INFO - Script journald.pass.sh using profile (all) OK

ctests:

100% tests passed, 0 tests failed out of 33

mpurg added 3 commits January 23, 2025 09:46
Checks that one of rsyslog/systemd-journald is active.
Satisfies Ubuntu 24.04 CIS control 6.1.1.4
@mpurg mpurg force-pushed the ubuntu2404_cis_6.1.1.4 branch from e43b83a to 32dbd43 Compare January 23, 2025 08:46
Copy link

codeclimate bot commented Jan 23, 2025

Code Climate has analyzed commit 32dbd43 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 2edb023 into ComplianceAsCode:master Jan 23, 2025
92 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants