-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kickstart remediation to service_kdump_disabled #12856
Conversation
Skipping CI for Draft Pull Request. |
481824c
to
24c741f
Compare
This change will cause that the kickstart file generated by OpenSCAP will contain `%addon com_redhat_kdump --disable` section. Fixes: ComplianceAsCode#12832
24c741f
to
bb719a4
Compare
Code Climate has analyzed commit bb719a4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
/packit build |
I can verify that this PR does add the section to the kickstart:
However, as mentioned, Something would need to generate an extra |
This change will cause that the kickstart file generated by OpenSCAP will contain
%addon com_redhat_kdump --disable
section.This PR partially addresses #12832 but it doesn't fix it completely.
Adding the section
%addon com_redhat_kdump --disable
to kickstart causes thatkdump
doesn't work in the installed system. Adding the section is equivalent to clicking on "Disable kdump" in the GUI installation. Both makes the kdump.service fail to start.However, disabling kdump this way will not make our rule service_kdump_disabled pass. This rule will still fail because it requires the kdump.service to be masked.
The
%addon com_redhat_kdump --disable
doesn't mask the kdump.service. And unfortunately, theservice --disable
command in kickstart also doesn't mask the kdump.service.In other words, we have hit one of the current issues of the Liteweight Anaconda hardening feature, that it doesn't mask the services. This has already been reported in #12282 (second part of the description section).