Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CIS reference URI for AlmaLinux 9 #12850

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

0intro
Copy link
Contributor

@0intro 0intro commented Jan 17, 2025

Description:

This change fixes the CIS reference URI for AlmaLinux 9. This allows the generated XML SCAP file to contain proper references to control IDs.

Fixes #12849.

Copy link

openshift-ci bot commented Jan 17, 2025

Hi @0intro. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 17, 2025
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Jan 17, 2025
@Mab879 Mab879 added this to the 0.1.76 milestone Jan 17, 2025
@Mab879 Mab879 added the bugfix Fixes to reported bugs. label Jan 17, 2025
This change fixes the CIS reference URI for AlmaLinux 9.
This allows the generated XML SCAP file to contain proper
references to control IDs.

Fixes ComplianceAsCode#12849.
@0intro 0intro force-pushed the almalinux9-reference-cis branch from 51ce89d to 7ec15b6 Compare January 17, 2025 15:20
Copy link

codeclimate bot commented Jan 17, 2025

Code Climate has analyzed commit 7ec15b6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879 Mab879 merged commit 215ccd6 into ComplianceAsCode:master Jan 20, 2025
99 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AlmaLinux 9 SCAP XML files are missing control IDs
2 participants