Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authselect profile minimal is now called local in RHEL10 #12846

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

ggbecker
Copy link
Member

@ggbecker ggbecker commented Jan 17, 2025

Description:

  • Authselect profile minimal is now called local in RHEL10.
  • Adjust variables and test scenarios to take this into account. Setting minimal variable to local should make the conversion transparent for users that have selected this in their profiles. RHEL10 profile will select minimal as well and it will translate correctly into local profile which should be the same as minimal. Minimal profile is not even available as deprecated in RHEL10.

@ggbecker ggbecker added bugfix Fixes to reported bugs. RHEL10 Red Hat Enterprise Linux 10 product related. labels Jan 17, 2025
@ggbecker ggbecker added this to the 0.1.76 milestone Jan 17, 2025
Copy link

github-actions bot commented Jan 17, 2025

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@ggbecker ggbecker force-pushed the authselect-sssd-profile branch from bfc9afb to f90488b Compare January 17, 2025 14:53
@ggbecker ggbecker marked this pull request as draft January 17, 2025 14:54
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 17, 2025
Adjust variables and test scenarios to take this into account.
Setting minimal variable to local should make the conversion transparent
for users that have selected this in their profiles. RHEL10 profile will
select minimal as well and it will translate correctly into local
profile which should be the same as minimal. Minimal profile is not
even available as deprecated in RHEL10.

Some test scenarios are not applicable to RHEL10 anymore due to changes
in how pam/authselect interact with the configuration files.
@ggbecker ggbecker force-pushed the authselect-sssd-profile branch from f90488b to feab9f3 Compare January 20, 2025 14:11
@ggbecker
Copy link
Member Author

I'm disabling a few of the test scenarios for RHEL10 as I wasn't able to make them work (maybe they are not applicable anymore and require new tests), @marcusburghardt if could help here, it's directly related to this:

https://github.com/ComplianceAsCode/content/pull/10430/files#r1922459785

@ggbecker ggbecker marked this pull request as ready for review January 20, 2025 14:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 20, 2025
Copy link

codeclimate bot commented Jan 20, 2025

Code Climate has analyzed commit feab9f3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Jan 20, 2025
@Mab879
Copy link
Member

Mab879 commented Jan 20, 2025

Automatus tests pass locally.

@Mab879
Copy link
Member

Mab879 commented Jan 20, 2025

Waving the Automatus tests as they are tests not found.

@Mab879 Mab879 merged commit fc46cfc into ComplianceAsCode:master Jan 20, 2025
103 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. RHEL10 Red Hat Enterprise Linux 10 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants