Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable_ctrlaltdel_burstaction: make sure config file exists #12841

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

ggbecker
Copy link
Member

Description:

  • disable_ctrlaltdel_burstaction: make sure config file exists
  • Starting from RHEL10, the file does not exist by default, it is expected that the file is created by copying /usr/lib/systemd/system.conf or creating a new one into /etc/systemd/ or /etc/systemd/system.conf.d/ for drop-in files.

Just touching the file should be enough for the test scenarios to work properly. The remediation should still be okay as they will create the file if is not there and it doesn't need to be a ini file with the [Manager] key since it loads the /usr/lib/systemd/system.conf file first and then loads the rest of the files giving priority to drop-in files, in other words they are loaded last so any configuration there should be the last to be loaded which should be the one taking place.

Starting from RHEL10, the file does not exist by default, it is expected
that the file is created by copying /usr/lib/systemd/system.conf or
creating a new one into /etc/systemd/ or /etc/systemd/system.conf.d/ for
drop-in files.

Just touching the file should be enough for the test scenarios to work
properly. The remediation should still be okay as they will create the
file if is not there and it doesn't need to be a ini file with the
[Manager] key since it loads the /usr/lib/systemd/system.conf file first
and then loads the rest of the files giving priority to drop-in files,
in other words they are loaded last so any configuration there should be
the last to be loaded which should be the one taking place.
@ggbecker ggbecker added the bugfix Fixes to reported bugs. label Jan 16, 2025
@ggbecker ggbecker added this to the 0.1.76 milestone Jan 16, 2025
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Jan 16, 2025

Code Climate has analyzed commit 1ef2ab0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Jan 16, 2025

/packit retest-failed

@Mab879 Mab879 self-assigned this Jan 16, 2025
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ ./automatus.py rule --datastream ../build/ssg-rhel10-ds.xml --libvirt qemu:///system automatus_rhel10 --remediate-using bash disable_ctrlaltdel_burstaction
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/mburket/Developer/ComplianceAsCode/content/tests/logs/rule-custom-2025-01-16-2001/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_disable_ctrlaltdel_burstaction
INFO - Script correct_value.pass.sh using profile (all) OK
INFO - Script line_not_there.fail.sh using profile (all) OK
INFO - Script wrong_value.fail.sh using profile (all) OK

Automatus passes locally.

@Mab879
Copy link
Member

Mab879 commented Jan 17, 2025

Waving the Automatus tests as they are failing due to tests not being found.

@Mab879 Mab879 merged commit 6066a3f into ComplianceAsCode:master Jan 17, 2025
107 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants