Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rules to replace audit_rules_mac_modification on Ubuntu #12828

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Jan 15, 2025

Description:

  • create new rules audit_rules_mac_modification_etc_apparmor and audit_rules_mac_modification_etc_apparmor_d
  • add rules to ubuntu 24.04 profile instead of audit_rules_mac_modification

Rationale:

@mpurg mpurg requested a review from a team as a code owner January 15, 2025 10:02
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 15, 2025
Copy link

openshift-ci bot commented Jan 15, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2404 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
xccdf_org.ssgproject.content_rule_audit_rules_mac_modification is missing in new data stream.

@dodys dodys self-assigned this Jan 16, 2025
@dodys dodys added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. CIS CIS Benchmark related. Update Profile Issues or pull requests related to Profiles updates. labels Jan 16, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 16, 2025
@dodys
Copy link
Contributor

dodys commented Jan 16, 2025

@mpurg this PR needs a rebase

@mpurg mpurg force-pushed the ubuntu_new_mac_rules branch from c2dfd62 to 4d43abd Compare January 16, 2025 18:57
@mpurg mpurg force-pushed the ubuntu_new_mac_rules branch from 4d43abd to a38b379 Compare January 16, 2025 19:00
@mpurg
Copy link
Contributor Author

mpurg commented Jan 16, 2025

@dodys rebased

Copy link

codeclimate bot commented Jan 16, 2025

Code Climate has analyzed commit a38b379 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 59de8de into ComplianceAsCode:master Jan 17, 2025
94 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants