Create a minimalist reproduction of content directory for unit tests #12819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
It's a great idea 👍 |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
jan-cerny
approved these changes
Jan 14, 2025
|
Failed CI tests for Fedora latest are workarounded by #12821 |
Just removed long text from files in order to make them easier to be read. Also some minor updates regarding indentation. Signed-off-by: Marcus Burghardt <[email protected]>
Signed-off-by: Marcus Burghardt <[email protected]>
Signed-off-by: Marcus Burghardt <[email protected]>
marcusburghardt
force-pushed
the
ssg_profiles_test_unit
branch
from
f451e48 to
8811f13
Compare
|
I just rebased after #12821 |
|
Code Climate has analyzed commit 8811f13 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.8% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With the introduction of #12797, during the development of unit tests it was not simple to mock all necessary information in runtime. The existing directory structure in
ssg-module/datawas not sufficient as well and I would like to avoid duplicating much data so it was temporarily used real content for unit tests, which is not ideal.In a discussion with @vojtapolasek , he proposed a minimalist reproduction of content directory including the necessary files for unit tests and this PR is just some minor improvements and cleanup on top of it.
More context in #12797 (comment)
Rationale:
Review Hints: