Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 24.04: Implement rule 5.3.3.3.1 Ensure password history remember is configured #12784

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Implement rule 5.3.3.3.1 Ensure password history remember is configured

Rationale:

  • Rewrite the remediation and tests of accounts_password_pam_pwhistory_rmember to use pam-auth-update
  • Satisfies Ubuntu 24.04 CIS control 5.3.3.3.1

@alanmcanonical alanmcanonical requested a review from a team as a code owner January 7, 2025 22:04
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 7, 2025
Copy link

openshift-ci bot commented Jan 7, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Jan 7, 2025

Start a new ephemeral environment with changes proposed in this pull request:

sle12 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys self-assigned this Jan 8, 2025
@dodys dodys added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Jan 8, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 8, 2025
@alanmcanonical alanmcanonical marked this pull request as draft January 9, 2025 14:59
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 9, 2025
@alanmcanonical alanmcanonical marked this pull request as ready for review January 10, 2025 13:16
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 10, 2025
@alanmcanonical alanmcanonical marked this pull request as draft January 15, 2025 17:43
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 15, 2025
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
OVAL for rule 'xccdf_org.ssgproject.content_rule_accounts_password_pam_pwhistory_remember' differs.
--- oval:ssg-accounts_password_pam_pwhistory_remember:def:1
+++ oval:ssg-accounts_password_pam_pwhistory_remember:def:1
@@ -1,3 +1,3 @@
 criteria AND
-criterion oval:ssg-test_pam_password_pam_pwhistory_remember:tst:1
-criterion oval:ssg-test_pam_password_pam_pwhistory_use_authtok:tst:1
+criterion oval:ssg-test_accounts_password_pam_pwhistory_enabled:tst:1
+criterion oval:ssg-test_accounts_password_pam_pwhistory_remember_parameter:tst:1

@alanmcanonical alanmcanonical force-pushed the ubt24_53331 branch 2 times, most recently from 2d54057 to 0a38043 Compare January 20, 2025 14:44
@alanmcanonical alanmcanonical marked this pull request as ready for review January 20, 2025 16:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 20, 2025
Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Password-Initial

Copy link

codeclimate bot commented Jan 21, 2025

Code Climate has analyzed commit 1c20e93 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit e4120cd into ComplianceAsCode:master Jan 21, 2025
95 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants