AppLauncher patch #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgvaughan
force-pushed
the
applauncher_patch
branch
from
4ac26bb to
07039ef
Compare
|
Thanks Tim! Looks good to me. The AppLauncher application is one of the last holdouts of swing code that has not gone through the javafx conversion yet. Thanks for making it look a bit better! Cheers Remco |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Remco, here are my suggestions for fixing the two issues I opened earlier. The icon size thing may be just a matter of taste, and I don't really like the approach of dynamically resizing the images in the cell viewer, but to me at least the resulting list is much easier to read:
Of course, feel free to ignore/modify as you wish!
Cheers,
Tim