Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularise TreeAnnotator #71

Closed
rbouckaert opened this issue Aug 6, 2023 · 1 comment
Closed

Modularise TreeAnnotator #71

rbouckaert opened this issue Aug 6, 2023 · 1 comment

Comments

@rbouckaert
Copy link
Member

rbouckaert commented Aug 6, 2023

TreeAnnotator has a number of options for setting the topology and for setting internal node heights.
Adding another method for either of these requires adding code to BeastFX, so cannot be done in packages.
Introducing interfaces for both of these and providing them as services in packages solves this problem.

In particular, it would be good to have an interface, say TopologySettingService that has two methods setTopology() for determining a topology given a set of trees and getName() for returning the name of the method so it can be used in the user interface.

Further, have another interface, say NodeHeightSettingService similarly with two methods setNodeHeights() to set node heights of a tree and getName() for the user interface.

@rbouckaert
Copy link
Member Author

Perhaps something for annotating branches could be useful too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant