-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularise TreeAnnotator #71
Comments
Perhaps something for annotating branches could be useful too. |
rbouckaert
added a commit
that referenced
this issue
Aug 9, 2023
rbouckaert
added a commit
that referenced
this issue
Aug 10, 2023
rbouckaert
added a commit
that referenced
this issue
Sep 10, 2023
rbouckaert
added a commit
that referenced
this issue
Sep 11, 2023
rbouckaert
added a commit
that referenced
this issue
Sep 28, 2023
rbouckaert
added a commit
that referenced
this issue
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TreeAnnotator has a number of options for setting the topology and for setting internal node heights.
Adding another method for either of these requires adding code to BeastFX, so cannot be done in packages.
Introducing interfaces for both of these and providing them as services in packages solves this problem.
In particular, it would be good to have an interface, say
TopologySettingService
that has two methodssetTopology()
for determining a topology given a set of trees andgetName()
for returning the name of the method so it can be used in the user interface.Further, have another interface, say
NodeHeightSettingService
similarly with two methodssetNodeHeights()
to set node heights of a tree andgetName()
for the user interface.The text was updated successfully, but these errors were encountered: