-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update winui ref to 2.6.2 #4182
Update winui ref to 2.6.2 #4182
Conversation
Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Huh, that's weird - it failed to build the Unit Tests project (but from the generated file):
I don't think we're using any of these anywhere (as we've only used the stable WinUI 2.x releases up to this point). We can probably add CS8305 to the ignore list of the UnitTest project? FYI @ranjeshj |
@RosarioPulella welcome back! FYI, they shipped a 2.6.2 stable, so we can switch to that now, re-test and then should be able to merge this? |
This is the existing behavior of the infinite canvas, and I believe it was intentional. Not sure who or when the control was added, but if you want to open up a discussion on this behavior I would recommend opening the separate issue or github discussion. The scope of this PR is just updating to winui 2.6.2 and the relevant issues the update fixes. |
Fixes
Updated to winui 2.6.2.
PR Type
What kind of change does this PR introduce?
Updated to winui 2.6.2, this fixes several issues.
ListViewExtention
sample opens fine in the sample build with (Debug|x64).What is the current behavior?
All libraries and the Sample App are built with a dependency on winui 2.6.1, which causes some issues in the sample app in certain non-critical conditions ( built in Debug mode ), and its causes some more impactful issues for the libraries we ship ( in particular the issue with the infinite canvas, listed in #4092 )
What is the new behavior?
All libraries and the Sample App are built with a dependency on winui 2.6.2, which fixes some issues in the sample app in certain non-critical conditions ( built in Debug mode ), and its fixes some more impactful issues for the libraries we ship ( in particular the issue with the infinite canvas )
PR Checklist
Please check if your PR fulfills the following requirements:
Other information