Enable item renaming and add tests for ApplicationDataStorageHelper #4173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is currently no methods for renaming items via the
IFileStorageHelper
interface.Also, the
ApplicationDataStorageHelper
needs more tests to validate that the file storage functionality is working as expected.What is the new behavior?
To support renaming items, I've added a new method
IFileStorageHelper.TryRenameItemAsync
.In addition, I've also updated the
IFileStorageHelper.DeleteItemAsync
method toTryDeleteItemAsync
to match the convention. It seems reasonable to expect that the file intended for deletion does not already exist, so the consumer should be able to handle this gracefully, without exceptions.Lastly, while adding tests for
ApplicationDataStorageHelper
I discovered that it doesn't handle items in sub-folders very well. So I've made some fixes there as well to support CRUD operations with files/folders in sub-directories.PR Checklist
Please check if your PR fulfills the following requirements:
Other information