PipelineBrush and effects refactoring

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/PipelineBrush/PipelineBrushXaml.bind

@@ -20,10 +20,10 @@
               Grid.Column="2"
               Height="400">
         <Border.Background>
-          <brushes:PipelineBrush Source="{effects:BackdropSource BackgroundSource=Backdrop}">
+          <brushes:PipelineBrush Source="{effects:BackdropSource}">
             <effects:LuminanceToAlphaEffect/>
             <effects:OpacityEffect Value="0.4"/>
-            <effects:BlendEffect Mode="Multiply" Source="{effects:BackdropSource BackgroundSource=Backdrop}"/>
+            <effects:BlendEffect Mode="Multiply" Source="{effects:BackdropSource}"/>
             <effects:BlurEffect Amount="16"/>
             <effects:ShadeEffect Color="#FF222222" Intensity="0.2"/>
             <effects:BlendEffect Mode="Overlay" Placement="Background" Source="{effects:TileSource Uri=ms-appx:///Assets/BrushAssets/NoiseTexture.png}"/>

Microsoft.Toolkit.Uwp.UI.Media/Brushes/AcrylicBrush.cs

@@ -26,15 +26,15 @@ public sealed class AcrylicBrush : XamlCompositionEffectBrushBase
         /// <summary>
         /// The <see cref="EffectSetter{T}"/> instance in use to set the tint color
         /// </summary>
-        private EffectSetter<Color> tintSetter;
+        private EffectSetter<Color> tintColorSetter;
 
         /// <summary>
         /// The <see cref="EffectSetter{T}"/> instance in use to set the tint mix amount
         /// </summary>
-        private EffectSetter<float> tintMixSetter;
+        private EffectSetter<float> tintOpacitySetter;
 
         /// <summary>
-        /// Gets or sets the source mode for the effect
+        /// Gets or sets the background source mode for the effect (the default is <see cref="AcrylicBackgroundSource.Backdrop"/>).
         /// </summary>
         public AcrylicBackgroundSource BackgroundSource
         {
@@ -103,60 +103,64 @@ private static void OnBlurAmountPropertyChanged(DependencyObject d, DependencyPr
         /// <summary>
         /// Gets or sets the tint for the effect
         /// </summary>
-        public Color Tint
+        public Color TintColor
         {
-            get => (Color)GetValue(TintProperty);
-            set => SetValue(TintProperty, value);
+            get => (Color)GetValue(TintColorProperty);
+            set => SetValue(TintColorProperty, value);
         }
 
         /// <summary>
-        /// Identifies the <see cref="Tint"/> dependency property.
+        /// Identifies the <see cref="TintColor"/> dependency property.
         /// </summary>
-        public static readonly DependencyProperty TintProperty = DependencyProperty.Register(
-            nameof(Tint),
+        public static readonly DependencyProperty TintColorProperty = DependencyProperty.Register(
+            nameof(TintColor),
             typeof(Color),
             typeof(AcrylicBrush),
-            new PropertyMetadata(default(Color), OnTintPropertyChanged));
+            new PropertyMetadata(default(Color), OnTintColorPropertyChanged));
 
         /// <summary>
-        /// Updates the UI when <see cref="Tint"/> changes
+        /// Updates the UI when <see cref="TintColor"/> changes
         /// </summary>
         /// <param name="d">The current <see cref="AcrylicBrush"/> instance</param>
-        /// <param name="e">The <see cref="DependencyPropertyChangedEventArgs"/> instance for <see cref="TintProperty"/></param>
-        private static void OnTintPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
+        /// <param name="e">The <see cref="DependencyPropertyChangedEventArgs"/> instance for <see cref="TintColorProperty"/></param>
+        private static void OnTintColorPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
         {
             if (d is AcrylicBrush brush &&
                 brush.CompositionBrush is CompositionBrush target)
             {
-                brush.tintSetter?.Invoke(target, (Color)e.NewValue);
+                brush.tintColorSetter?.Invoke(target, (Color)e.NewValue);
             }
         }
 
         /// <summary>
-        /// Gets or sets the tint mix factor for the effect
+        /// Gets or sets the tint opacity factor for the effect
         /// </summary>
-        public double TintMix { get; set; }
+        public double TintOpacity
+        {
+            get => (double)GetValue(TintOpacityProperty);
+            set => SetValue(TintOpacityProperty, value);
+        }
 
         /// <summary>
-        /// Identifies the <see cref="TintMix"/> dependency property.
+        /// Identifies the <see cref="TintOpacity"/> dependency property.
         /// </summary>
-        public static readonly DependencyProperty TintMixProperty = DependencyProperty.Register(
-            nameof(TintMix),
+        public static readonly DependencyProperty TintOpacityProperty = DependencyProperty.Register(
+            nameof(TintOpacity),
             typeof(double),
             typeof(AcrylicBrush),
-            new PropertyMetadata(0.0, OnTintMixPropertyChanged));
+            new PropertyMetadata(0.0, OnTintOpacityPropertyChanged));
 
         /// <summary>
-        /// Updates the UI when <see cref="TintMix"/> changes
+        /// Updates the UI when <see cref="TintOpacity"/> changes
         /// </summary>
         /// <param name="d">The current <see cref="AcrylicBrush"/> instance</param>
-        /// <param name="e">The <see cref="DependencyPropertyChangedEventArgs"/> instance for <see cref="TintMixProperty"/></param>
-        private static void OnTintMixPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
+        /// <param name="e">The <see cref="DependencyPropertyChangedEventArgs"/> instance for <see cref="TintOpacityProperty"/></param>
+        private static void OnTintOpacityPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
         {
             if (d is AcrylicBrush brush &&
                 brush.CompositionBrush is CompositionBrush target)
             {
-                brush.tintMixSetter?.Invoke(target, (float)(double)e.NewValue);
+                brush.tintOpacitySetter?.Invoke(target, (float)(double)e.NewValue);
             }
         }
 
@@ -200,19 +204,19 @@ protected override PipelineBuilder OnBrushRequested()
             {
                 case AcrylicBackgroundSource.Backdrop:
                     return PipelineBuilder.FromBackdropAcrylic(
-                        Tint,
-                        out tintSetter,
-                        (float)TintMix,
-                        out tintMixSetter,
+                        TintColor,
+                        out this.tintColorSetter,
+                        (float)TintOpacity,
+                        out this.tintOpacitySetter,
                         (float)BlurAmount,
-                        out this.blurAmountSetter,
+                        out blurAmountSetter,
                         TextureUri);
                 case AcrylicBackgroundSource.HostBackdrop:
                     return PipelineBuilder.FromHostBackdropAcrylic(
-                        Tint,
-                        out tintSetter,
-                        (float)TintMix,
-                        out tintMixSetter,
+                        TintColor,
+                        out this.tintColorSetter,
+                        (float)TintOpacity,
+                        out this.tintOpacitySetter,
                         TextureUri);
                 default: throw new ArgumentOutOfRangeException(nameof(BackgroundSource), $"Invalid acrylic source: {BackgroundSource}");
             }

Microsoft.Toolkit.Uwp.UI.Media/Brushes/BackdropBlurBrush.cs

@@ -20,7 +20,7 @@ public class BackdropBlurBrush : XamlCompositionEffectBrushBase
         /// <summary>
         /// The <see cref="EffectSetter{T}"/> instance currently in use
         /// </summary>
-        private EffectSetter<float> setter;
+        private EffectSetter<float> amountSetter;
 
         /// <summary>
         /// Gets or sets the amount of gaussian blur to apply to the background.
@@ -50,14 +50,14 @@ private static void OnAmountChanged(DependencyObject d, DependencyPropertyChange
             if (d is BackdropBlurBrush brush &&
                 brush.CompositionBrush is CompositionBrush target)
             {
-                brush.setter?.Invoke(target, (float)brush.Amount);
+                brush.amountSetter?.Invoke(target, (float)brush.Amount);
             }
         }
 
         /// <inheritdoc/>
         protected override PipelineBuilder OnBrushRequested()
         {
-            return PipelineBuilder.FromBackdrop().Blur((float)Amount, out setter);
+            return PipelineBuilder.FromBackdrop().Blur((float)Amount, out this.amountSetter);
         }
     }
 }

Microsoft.Toolkit.Uwp.UI.Media/Effects/BlendEffect.cs

@@ -30,7 +30,7 @@ public sealed class BlendEffect : IPipelineEffect
         public ImageBlendMode Mode { get; set; }
 
         /// <summary>
-        /// Gets or sets the placement of the input builder with respect to the current one (the default is <see cref="Placement.Foreground"/>)
+        /// Gets or sets the placement of the input builder with respect to the current one (the default is <see cref="Media.Placement.Foreground"/>)
         /// </summary>
         public Placement Placement { get; set; } = Placement.Foreground;
 

Microsoft.Toolkit.Uwp.UI.Media/Effects/Extensions/AcrylicSourceExtension.cs

@@ -18,9 +18,9 @@ namespace Microsoft.Toolkit.Uwp.UI.Media.Effects
     public sealed class AcrylicSourceExtension : MarkupExtension
     {
         /// <summary>
-        /// Gets or sets the background source mode for the effect
+        /// Gets or sets the background source mode for the effect (the default is <see cref="AcrylicBackgroundSource.Backdrop"/>).
         /// </summary>
-        public AcrylicBackgroundSource BackgroundSource { get; set; }
+        public AcrylicBackgroundSource BackgroundSource { get; set; } = AcrylicBackgroundSource.Backdrop;
 
         /// <summary>
         /// Gets or sets the blur amount for the effect
@@ -31,12 +31,12 @@ public sealed class AcrylicSourceExtension : MarkupExtension
         /// <summary>
         /// Gets or sets the tint for the effect
         /// </summary>
-        public Color Tint { get; set; }
+        public Color TintColor { get; set; }
 
         /// <summary>
         /// Gets or sets the color for the tint effect
         /// </summary>
-        public double TintMix { get; set; }
+        public double TintOpacity { get; set; }
 
         /// <summary>
         /// Gets or sets the <see cref="Uri"/> to the texture to use
@@ -48,8 +48,8 @@ protected override object ProvideValue()
         {
             return BackgroundSource switch
             {
-                AcrylicBackgroundSource.Backdrop => PipelineBuilder.FromBackdropAcrylic(Tint, (float)TintMix, (float)BlurAmount, TextureUri),
-                AcrylicBackgroundSource.HostBackdrop => PipelineBuilder.FromHostBackdropAcrylic(Tint, (float)TintMix, TextureUri),
+                AcrylicBackgroundSource.Backdrop => PipelineBuilder.FromBackdropAcrylic(this.TintColor, (float)this.TintOpacity, (float)BlurAmount, TextureUri),
+                AcrylicBackgroundSource.HostBackdrop => PipelineBuilder.FromHostBackdropAcrylic(this.TintColor, (float)this.TintOpacity, TextureUri),
                 _ => throw new ArgumentException($"Invalid source mode for acrylic effect: {BackgroundSource}")
             };
         }

Microsoft.Toolkit.Uwp.UI.Media/Effects/Extensions/BackdropSourceExtension.cs

@@ -16,9 +16,9 @@ namespace Microsoft.Toolkit.Uwp.UI.Media.Effects
     public sealed class BackdropSourceExtension : MarkupExtension
     {
         /// <summary>
-        /// Gets or sets the backdrop source to use to render the effect
+        /// Gets or sets the background source mode for the effect (the default is <see cref="AcrylicBackgroundSource.Backdrop"/>).
         /// </summary>
-        public AcrylicBackgroundSource BackgroundSource { get; set; }
+        public AcrylicBackgroundSource BackgroundSource { get; set; } = AcrylicBackgroundSource.Backdrop;
 
         /// <inheritdoc/>
         protected override object ProvideValue()