Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled .NetCore tests. #3217

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Enabled .NetCore tests. #3217

merged 2 commits into from
Apr 2, 2020

Conversation

azchohfi
Copy link
Contributor

@azchohfi azchohfi commented Apr 2, 2020

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes

What is the current behavior?

Only UWP tests are running on build.

What is the new behavior?

.Net Core projects run tests as well as UWP ones.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Apr 2, 2020

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned Kyaa-dost Apr 2, 2020
@azchohfi azchohfi force-pushed the enableNetCoreTests branch from 6608970 to d56b423 Compare April 2, 2020 08:12
@azchohfi azchohfi requested a review from michael-hawker April 2, 2020 15:49
@azchohfi azchohfi merged commit a4710a7 into master Apr 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the enableNetCoreTests branch April 2, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants