-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β Fix Unit Tests for Integration with CI Builds πππ #3207
Conversation
More work is needed that we're not setup for in the toolkit yet to support these types of tests properly.
To be removed later with WinUI 3 transition.
Issue was originally introduced when YAML front-matter support was added in e94daf5
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request π |
This is great! Just abandon the other one. The commits are the same. |
Lets just fix the build issue and merge master into it. |
@azchohfi one of the build issues was a Stylecop issue I'm fixing now, but the other one seems configuration related to a project I didn't touch? Thoughts? https://dev.azure.com/dotnet/WindowsCommunityToolkit/_build/results?buildId=31000&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=d1e88c09-dceb-53c1-5579-19c846f3526a&l=6354
|
Fixes #2133
Continuation of @azchohfi's #3165 (should we force-merge that to make this easier to compare or abandon the other one???)
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some Unit Tests were not passing, this PR ignores edge-cases scenarios in Markdown tests, fixes markdown tests, or fixes issues in the Toolkit. See #3200 for long-term potential plans for Markdown.
What is the new behavior?
Fixed issue with Header 2 and YAML parsing, fixed another case with Tables.
See Issue #3196 we need Mocking for ConnectionHelper, so Ignore those tests for now
See Issue #3198 for extra tests we added around NullableBooleanMarkupExtension
Fixed the scenario (which was invalid) or ignored other Markdown Unit Tests
PR Checklist
Please check if your PR fulfills the following requirements: