Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βœ” Fix Unit Tests for Integration with CI Builds πŸŽ‰πŸŽ‰πŸŽ‰ #3207

Merged
merged 17 commits into from
Apr 1, 2020

Conversation

michael-hawker
Copy link
Member

Fixes #2133

Continuation of @azchohfi's #3165 (should we force-merge that to make this easier to compare or abandon the other one???)

PR Type

What kind of change does this PR introduce?

  • Refactoring - Fixing Unit Tests
  • Build or CI related changes

What is the current behavior?

Some Unit Tests were not passing, this PR ignores edge-cases scenarios in Markdown tests, fixes markdown tests, or fixes issues in the Toolkit. See #3200 for long-term potential plans for Markdown.

What is the new behavior?

Fixed issue with Header 2 and YAML parsing, fixed another case with Tables.
See Issue #3196 we need Mocking for ConnectionHelper, so Ignore those tests for now
See Issue #3198 for extra tests we added around NullableBooleanMarkupExtension
Fixed the scenario (which was invalid) or ignored other Markdown Unit Tests

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Apr 1, 2020

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request πŸ™Œ

@ghost ghost assigned azchohfi Apr 1, 2020
@azchohfi
Copy link
Contributor

azchohfi commented Apr 1, 2020

This is great! Just abandon the other one. The commits are the same.

@azchohfi
Copy link
Contributor

azchohfi commented Apr 1, 2020

Lets just fix the build issue and merge master into it.

@michael-hawker
Copy link
Member Author

@azchohfi one of the build issues was a Stylecop issue I'm fixing now, but the other one seems configuration related to a project I didn't touch? Thoughts? https://dev.azure.com/dotnet/WindowsCommunityToolkit/_build/results?buildId=31000&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=d1e88c09-dceb-53c1-5579-19c846f3526a&l=6354

"D:\a\1\s\Windows Community Toolkit.sln" (Build target) (1) ->
       "D:\a\1\s\UnitTests\UnitTests.Notifications.NetCore\UnitTests.Notifications.NetCore.csproj" (default target) (16) ->
       (CoreCompile target) -> 
         CSC : warning SA0001: XML comment analysis is disabled due to project configuration [D:\a\1\s\UnitTests\UnitTests.Notifications.NetCore\UnitTests.Notifications.NetCore.csproj]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Tests does not run with latest Master
3 participants