-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Popup.CloseAsync()
#1223
Add Popup.CloseAsync()
#1223
Conversation
Hey @JoonghyunCho! We're seeing a Tizen error in the build. Could you take a look? C:\hostedtoolcache\windows\dotnet\packs\Samsung.Tizen.Sdk\7.0.114\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : The api-version specified in tizen-manifest file is 7. [D:\a\1\s\samples\CommunityToolkit.Maui.Sample\CommunityToolkit.Maui.Sample.csproj::TargetFramework=net7.0-tizen]
C:\hostedtoolcache\windows\dotnet\packs\Samsung.Tizen.Sdk\7.0.114\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : Current target framework net7.0-tizen is not supported in this api-version. [D:\a\1\s\samples\CommunityToolkit.Maui.Sample\CommunityToolkit.Maui.Sample.csproj::TargetFramework=net7.0-tizen] |
Absolutely! Will take a look during the weekend or early next week :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment, but nothing that would block you from merging this puppy (:
src/CommunityToolkit.Maui.Core/Handlers/Popup/PopupHandler.net.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of Change
This PR adds a new API to
Popup
:Task Popup.CloseAsync()
Linked Issues
Popup.CloseAsync()
#1222PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRPopup.CloseAsync()
MicrosoftDocs/CommunityToolkit#285Additional information