-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DataTable crash on resize when columns don't fit #599
Fix DataTable crash on resize when columns don't fit #599
Conversation
08c2fbf
to
3eadb5a
Compare
Head branch was pushed to by a user without write access
1c52238
to
6cc6525
Compare
6cc6525
to
dc8741a
Compare
0d73135
to
65d4c84
Compare
Head branch was pushed to by a user without write access
65d4c84
to
075b815
Compare
11f292a
to
6ac81c4
Compare
6ac81c4
to
e375d9a
Compare
e375d9a
to
6aab97d
Compare
Suggested in code review, see !599 Co-authored-by: Andrii Chebukin <[email protected]>
6aab97d
to
e89df6e
Compare
@Arlodotexe, @michael-hawker, @xperiandri Could you please take a look at this MR when you have time? It's been reviewed a while ago, but seems to be stuck because of missing pipeline checks. |
Apply PR Feedback
@pcfist sorry about that, GitHub holds things for new contributors. FYI @Arlodotexe. I've checked this locally. Saw it again and thought I remember seeing a fix before. We'll get this merged today. Thanks for the contribution! 🦙❤️ |
DataTable
sometimes crashes on resize, typically when it gets narrow enough for its columns not to fit. Crash happens inMeasureOverride
because of negative value passed toSize
ctor.The easiest way to reproduce is to set
DataTable
'sHorizontalAlignment
toLeft
to disable "stretching" behavior. The following code snippet may be used (slightly modified version ofDataTableSample.xaml
):This PR adds a check to make sure width value used in
MeasureOverride()
are non-negative.