-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SizerBase] Orientation and Cursor not set correctly #388
Closed
Labels
bug 🐛
Something isn't working
experiment 🧪
Used to track issues that are experiments (or their linked discussions)
issue 🧪
Used for tracking an Issue/Bug/Feature of an open Experiment/Component
Comments
Huh, noticing the same behavior for Ah, different code, but same root cause, the initial pass runs and sets the |
michael-hawker
added a commit
to michael-hawker/Labs-Windows
that referenced
this issue
Apr 15, 2023
Removes Mouse Extension from XAML Template and does in code-behind as to remove the need to set the Cursor property directly via binding By setting the Cursor DependencyProperty we were losing our detection mechanism, now if it's set it's an explicit override, otherwise we use our logic based on Orientation property Also, switches to new CommunityToolkit.*.Extensions Dependency vs. old copies of Tree helpers Fixes some doc typos Bumps version, tested on UWP, WASDK, and Uno.UI/WASM
michael-hawker
added a commit
to michael-hawker/Labs-Windows
that referenced
this issue
Apr 15, 2023
Removes Mouse Extension from XAML Template and does in code-behind as to remove the need to set the Cursor property directly via binding By setting the Cursor DependencyProperty we were losing our detection mechanism, now if it's set it's an explicit override, otherwise we use our logic based on Orientation property Also, switches to new CommunityToolkit.*.Extensions Dependency vs. old copies of Tree helpers Fixes some doc typos Bumps version, tested on UWP, WASDK, and Uno.UI/WASM
michael-hawker
added a commit
to michael-hawker/Labs-Windows
that referenced
this issue
Apr 15, 2023
Removes Mouse Extension from XAML Template and does in code-behind as to remove the need to set the Cursor property directly via binding By setting the Cursor DependencyProperty we were losing our detection mechanism, now if it's set it's an explicit override, otherwise we use our logic based on Orientation property Also, switches to new CommunityToolkit.*.Extensions Dependency vs. old copies of Tree helpers Fixes some doc typos Bumps version, tested on UWP, WASDK, and Uno.UI/WASM
michael-hawker
added a commit
to michael-hawker/Labs-Windows
that referenced
this issue
Apr 15, 2023
Removes Mouse Extension from XAML Template and does in code-behind as to remove the need to set the Cursor property directly via binding By setting the Cursor DependencyProperty we were losing our detection mechanism, now if it's set it's an explicit override, otherwise we use our logic based on Orientation property Also, switches to new CommunityToolkit.*.Extensions Dependency vs. old copies of Tree helpers Fixes some doc typos Bumps version, tested on UWP, WASDK, and Uno.UI/WASM
This was referenced Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something isn't working
experiment 🧪
Used to track issues that are experiments (or their linked discussions)
issue 🧪
Used for tracking an Issue/Bug/Feature of an open Experiment/Component
Parent Experiment: #101
Figured out what was going on with the cursor not properly updating when the Orientation is Horizontal (like in the sample) - regression from current Toolkit version.
It's this code here:
Labs-Windows/labs/SizerBase/src/SizerBase.Properties.cs
Lines 98 to 110 in 9045236
Since we set the value of the dependency property, when the initial pass run on load sets it to
SizeWestEast
. Then the detection logic runs andOrientation
is changed toHorizontal
, but the set gets ignored the 2nd time as the prop has been set...Think this was abstracted in the old code as the inner class held that info.
Here, I think we need to just have the private value tracking what the cursor should be and leave the Cursor property for overrides? Will think about it more and get back to it as a separate fix.
Effects UWP and WASM (basically WinUI 2), Windows App SDK uses a different setup, so I think is uneffected.
Originally posted by @michael-hawker in #101 (comment)
(Will have to create a new issue template for experiment bugs...)
The text was updated successfully, but these errors were encountered: