Draft - Update TokenizingTextBox usage for PeoplePicker

[michael-hawker]

Fixes #

Update the People Picker to use the new TokenizingTextBox

PR Type

What kind of change does this PR introduce?

• Refactoring

What is the current behavior?

Uses preview TokenizingTextBox

What is the new behavior?

Uses new TokenizingTextBox

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

TODO

• Update People Picker to inherit from TokenizingTextBox instead of containing one.
• Update once TokenizingTextBox remaining issues WindowsCommunityToolkit#3289 is fixed.

[ghost]

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[michael-hawker]

@azchohfi I had trouble building the WPF/XAML Islands app with this error:

2>H:\code\WindowsGraphControls\Samples\XAML Islands\WPF-Core-GraphApp\WPF-Core-GraphApp.csproj : error MSB4236: The SDK 'Microsoft.NET.Sdk.WindowsDesktop' specified could not be found.  H:\code\WindowsGraphControls\Samples\XAML Islands\WPF-Core-GraphApp\WPF-Core-GraphApp.csproj

Is there a new change I need to make to the project file?

Also, I noticed that the Microsoft.SourceLink.Vsts.Git package is marked deprecated. Should we remove that from here and the main repo?

[azchohfi]

Are you sure you have the Desktop dev workload installed on your VS?
About the package, we need to migrate to Microsoft.SourceLink.AzureRepos.Git.

[michael-hawker]

@azchohfi I have these workloads installed:

Is there a sub-item I need to check?

[michael-hawker]

Alright, I think the last bit left here is to be able to fall back on the Users API as MGT does here.

Then we should be good to go.

@azchohfi I'm going to try the sub-module thing as a test for the sample app tomorrow. Then that limits the crazy NuGet stuff for now. If not I'll fall-back to the weirdness, but will I need an official NuGet reference or could I do it with MyGet still?

[azchohfi]

You could do it with myget, but I don't think we should. All you have to do is add the myget to the nuget.config file, but we need to remove it before we ship this to nuget.

[michael-hawker]

Wondering if we just make the PeoplePicker a behavior and style in the future though that's not as friendly... anyway, going to merge this in and we can sort out changes later. This should be enough for the sample app.