Dapr example and tests #394
Conversation
There was a problem hiding this comment.
Copilot reviewed 15 out of 30 changed files in this pull request and generated no comments.
Files not reviewed (15)
- .devcontainer/devcontainer.json: Language not supported
- .devcontainer/post-create.sh: Language not supported
- CommunityToolkit.Aspire.sln: Language not supported
- Directory.Packages.props: Language not supported
- examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.AppHost/CommunityToolkit.Aspire.Hosting.Dapr.AppHost.csproj: Language not supported
- examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.AppHost/Properties/launchSettings.json: Language not supported
- examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.AppHost/appsettings.json: Language not supported
- examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceA/CommunityToolkit.Aspire.Hosting.Dapr.ServiceA.csproj: Language not supported
- examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceA/Properties/launchSettings.json: Language not supported
- examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceA/appsettings.json: Language not supported
- examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceB/CommunityToolkit.Aspire.Hosting.Dapr.ServiceB.csproj: Language not supported
- examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceB/Properties/launchSettings.json: Language not supported
- examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceB/appsettings.json: Language not supported
- examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceC/CommunityToolkit.Aspire.Hosting.Dapr.ServiceC.csproj: Language not supported
- .github/workflows/dotnet-ci.yml: Evaluated as low risk
Comments suppressed due to low confidence (1)
examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceB/Program.cs:22
- The new behavior for handling weather forecasts and pub/sub events should be covered by tests.
app.MapGet("/weatherforecast", async (DaprClient client) =>
|
CI is failing because the install location of Dapr isn't into the paths that are hard-coded to be used for lookup in the |
|
@aaronpowell maybe add this to the // Add all the paths that are reachable via the `PATH` environment variable:
var possibleDaprPaths = Environment.GetEnvironmentVariable("PATH")?
.Split(Path.PathSeparator)
.Select(path => Path.Combine(path, "dapr"))
.Where(path => File.Exists(path)) ?? [];
foreach(var path in possibleDaprPaths){
yield return path;
}It should search truth the |
This seems fine on Linux runners but it's not working on Windows and I can't seem to get Aspire to do any sort of logging on what paths it is trying to look at during the tests. |
* Adding the ability to do a maven build in the app host This uses an event to run the mvnw build (or it can be customised via options), so it is only used when the app host is running the resource Fixes #339 * Adding a 'build with maven' command Allows you to rebuild the java app without having to restart the whole app host. * Expanding test coverage * Some more tests
|
That logic is not complete windows needs to look for .exe and .cmd |
Yep, can't believe it took me half a day to notice that 🤣 Tests are still failing, I've asked on the Dapr discord |
|
@aaronpowell hm it looks like it's a CI issue. Because lokal on my Windows machine the tests are working:
|
|
The problem is actually that the dapr init silently failed.
|
|
@aaronpowell can you push an emtpy commit to trigger CI again. I guess this will solve the issue. Sadly I can't push to your branch |
|
Ah, so it will require those container images? Windows runners don't have WSL to they need Windows container images. Probably going to have to disable that test on Windows CI |
|
@aaronpowell oh okay I was not aware of that. Yeah so I guess we need to deactive the test. Are there any windows runners with wsl support? |
|
@aaronpowell maybe we can try todo this befor the docker install:
|
It might be worth exploring but I'm going to disable the test for now as that kind of a refactor is beyond the scope of what should be in this workstream. |
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
Minimum allowed line rate is |
* Dapr migration initial import (#378) * Dropping files from Aspire repo * Moving to the right namespace/folder naming * Adding to solution and getting it to compile * Adding in the Dapr tests from the Aspire repo Had to remove the DaprSchemaTests file as we can't do schema tests (missing a lot of infrastructure from the Aspire repo). Had to edit the DaprTests to not use EnvironmentVariableEvaluator, which we can't leverage as it uses some internal types from Aspire.Hosting. This means that our testing of the environment variables is slightly different, and the values we assert against are not the docker internal host endpoints, but the public endpoints * Dapr azure hosting ext (#371) * Create Dap Azure extensions project Create Dapr Azure Redis project Create Example AppHost + ApiService * Work in progress Create Dapr resource for provisioning * Remove specific resource as not generating properly Use AddAzureInfrastructure * Updated to use secret refs * Fix - Remove code used for testing Add AzureDaprComponentResource Start of unit tests * Unit tests + Fixes based on unit tests * remove bicep file * Tests for AzureRedis * Add Readme and perform small cleanup tasks * Update src/CommunityToolkit.Aspire.Hosting.Dapr.AzureExtensions/ApplicationModel/AzureDaprComponentResource.cs Co-authored-by: Aaron Powell <[email protected]> * Apply suggestions from code review Co-authored-by: Aaron Powell <[email protected]> * Revert unintentional change to Java.AppHost * Update tests/CommunityToolkit.Aspire.Hosting.Dapr.AzureRedis.Tests/ResourceCreationTests.cs Co-authored-by: Aaron Powell <[email protected]> * Updated azure redis documentation also added missing xmldocs for api * correct unit test approach * remove unnecessary comment * null checking * More null checking * Update Azure redis readme * Update AzureExtension readme * move extensions to shared files remove Dapr Azure extensions project make dapr azure extensions internal include extensions in dapr redis package include extensions in dapr extensions tests make dapr redis internals visible to dapr redis tests * change redisCache to infra rename source to redisBuilder --------- Co-authored-by: Aaron Powell <[email protected]> * Fixing broken sln * Dapr example and tests (#394) * Migrating sample from dotnet/aspire repo * Adding dapr tests * Adding dapr setup to CI workflow * Following the setup-dapr instructions * Debugging CI * Falling back to looking at PATH * Fixing line endings replacement * Added PATH lookup to Windows * Adding some diagnostic info * Changing log level * init was only running on linux, which I think is wrong * Turning up logging * Bypass logging * Interpolated strings * Adding resource logger service * Java app build extension (#348) * Adding the ability to do a maven build in the app host This uses an event to run the mvnw build (or it can be customised via options), so it is only used when the app host is running the resource Fixes #339 * Adding a 'build with maven' command Allows you to rebuild the java app without having to restart the whole app host. * Expanding test coverage * Some more tests * Windows exe needs a file extension * Rolling back some changes * Renaming step * Tidying up the tests * Requiring docker for dapr tests * Adding codeowners * Moving dapr extensions to use our dapr package * Forgot to update the tests project * Adding some assembly filters * Adding readme updates * Slight break in the markdown --------- Co-authored-by: Brett Smith <[email protected]>
This pull request introduces Dapr integration into the project by adding necessary configurations and setup steps. The changes span multiple files to ensure Dapr is properly initialized and used across various services.
Dapr Integration:
.devcontainer/devcontainer.json: Added the Dapr CLI feature to the dev container configuration..devcontainer/post-create.sh: Added Dapr initialization commands to the post-create script..github/workflows/dotnet-ci.yml: Included Dapr setup steps and environment variables in the CI workflow. [1] [2] [3]Directory.Packages.props: Added Dapr package versions forDapr.AspNetCoreandDapr.Client.Project Configuration:
CommunityToolkit.Aspire.sln: Added new Dapr-related projects to the solution file. [1] [2] [3]Example Projects:
examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.AppHost/CommunityToolkit.Aspire.Hosting.Dapr.AppHost.csproj: Created a new project for Dapr AppHost.examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.AppHost/Program.cs: Added code to set up Dapr state store and pub/sub components.examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.AppHost/Properties/launchSettings.json: Configured launch settings for the Dapr AppHost project.examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.AppHost/appsettings.json: Added logging configuration for the Dapr AppHost project.examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.AppHost/pubsub.yaml: Added a YAML configuration for the Dapr pub/sub component.Service Projects:
examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceA/CommunityToolkit.Aspire.Hosting.Dapr.ServiceA.csproj: Created a new project for Service A with Dapr integration.examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceA/Program.cs: Added code to handle Dapr state and pub/sub in Service A.examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceA/Properties/launchSettings.json: Configured launch settings for Service A.examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceA/appsettings.json: Added logging configuration for Service A.examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceB/CommunityToolkit.Aspire.Hosting.Dapr.ServiceB.csproj: Created a new project for Service B with Dapr integration.examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceB/Program.cs: Added code to handle Dapr pub/sub in Service B.examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceB/Properties/launchSettings.json: Configured launch settings for Service B.examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.ServiceB/appsettings.json: Added logging configuration for Service B.