Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency information to setup.py #248

Closed
wants to merge 1 commit into from
Closed

Add dependency information to setup.py #248

wants to merge 1 commit into from

Conversation

ahills
Copy link

@ahills ahills commented Jul 5, 2024

Only the RPM spec file includes package dependency information, which makes the repository difficult to work with in other packaging contexts.

Only the RPM spec file includes package dependency information, which
makes the repository difficult to work with in other packaging contexts.

The initial list was extracted from the spec file:

```
rpmspec --query --requires ./charon.spec \
  | sed -n -e "s/^$(rpmspec -E 'python%{python3_pkgversion}-')\(.*\)$/\"\1\",/p"
```

However, two transformations were performed by hand:
- `dateutil` → `python-dateutil`
- `ruamel-yaml` → `ruamel.yaml`
@ligangty
Copy link
Member

ligangty commented Jul 8, 2024

Hi @ahills , the direct dependencies are defined in requirements.txt, so I added them in this PR: #252 . The charon.spec is working for rpm which uses all dependencies including the transitive ones. It is not good options for the pip installation.
Please help review that PR to see if any problems.

@ahills ahills closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants