Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gallery changing image every time a task finishes #2125

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

christian-byrne
Copy link
Collaborator

@christian-byrne christian-byrne commented Jan 2, 2025

Fixes issue:

This PR also changes the gallery items to be evaluated lazily on the condition that the gallery is open, instead of every time the tasks change.

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne requested review from a team as code owners January 2, 2025 17:17
@huchenlei huchenlei merged commit 5c7cbe9 into main Jan 2, 2025
10 checks passed
@huchenlei huchenlei deleted the gallery-active-item branch January 2, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants