-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hasWASMSupport to capabilities #7784
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so the launching site can query if wasm is enabled to see if it needs to insert the required headers, so we can then in turn make it optional on those being set to also require matching headers. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Icd73081809abb8098c21bc61a8357869db45ff6c
eszkadev
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected
caolanm
added a commit
to caolanm/richdocuments
that referenced
this pull request
Dec 6, 2023
caolanm
added a commit
to caolanm/richdocuments
that referenced
this pull request
Dec 6, 2023
which was added in: CollaboraOnline/online#7784 Signed-off-by: Caolán McNamara <[email protected]>
Merged
4 tasks
juliusknorr
pushed a commit
to nextcloud/richdocuments
that referenced
this pull request
Dec 6, 2023
which was added in: CollaboraOnline/online#7784 Signed-off-by: Caolán McNamara <[email protected]>
mmeeks
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me - thanks Caolan =)
juliusknorr
pushed a commit
to nextcloud/richdocuments
that referenced
this pull request
Dec 7, 2023
which was added in: CollaboraOnline/online#7784 Signed-off-by: Caolán McNamara <[email protected]>
hcvcastro
pushed a commit
to hcvcastro/nextcloud-richdocuments
that referenced
this pull request
Nov 21, 2024
which was added in: CollaboraOnline/online#7784 Signed-off-by: Caolán McNamara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so the launching site can query if wasm is enabled to see if it needs to insert the required headers, so we can then in turn make it optional on those being set to also require matching headers.
Change-Id: Icd73081809abb8098c21bc61a8357869db45ff6c
Summary
TODO
Checklist
make check
make run
and manually verified that everything looks okay