Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hasWASMSupport to capabilities #7784

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

caolanm
Copy link
Contributor

@caolanm caolanm commented Dec 5, 2023

so the launching site can query if wasm is enabled to see if it needs to insert the required headers, so we can then in turn make it optional on those being set to also require matching headers.

Change-Id: Icd73081809abb8098c21bc61a8357869db45ff6c

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

so the launching site can query if wasm is enabled to see if it needs to
insert the required headers, so we can then in turn make it optional on
those being set to also require matching headers.

Signed-off-by: Caolán McNamara <[email protected]>
Change-Id: Icd73081809abb8098c21bc61a8357869db45ff6c
@caolanm caolanm requested a review from Ashod December 5, 2023 17:08
Copy link
Contributor

@eszkadev eszkadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@caolanm caolanm merged commit 5f1c943 into master Dec 6, 2023
@caolanm caolanm deleted the private/caolanm/add_wasm_to_capabilities branch December 6, 2023 09:58
caolanm added a commit to caolanm/richdocuments that referenced this pull request Dec 6, 2023
caolanm added a commit to caolanm/richdocuments that referenced this pull request Dec 6, 2023
juliusknorr pushed a commit to nextcloud/richdocuments that referenced this pull request Dec 6, 2023
Copy link
Contributor

@mmeeks mmeeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me - thanks Caolan =)

juliusknorr pushed a commit to nextcloud/richdocuments that referenced this pull request Dec 7, 2023
hcvcastro pushed a commit to hcvcastro/nextcloud-richdocuments that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants