Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add fix for combobox indicator and padding #145

Merged
merged 2 commits into from
May 1, 2019
Merged

PR: Add fix for combobox indicator and padding #145

merged 2 commits into from
May 1, 2019

Conversation

goanpeca
Copy link
Collaborator

@goanpeca goanpeca commented Apr 30, 2019

Fixes #132

The active element is now on bold, was the only thing I could manage to do. It seems the QComboBox implementation under the hood is funky.

Screen Shot 2019-04-30 at 12 42 32

On Spyder I still se a small artifact on the corners, but it must be related to something else?

Screen Shot 2019-04-30 at 12 45 05

Tested on OSX only

Copy link
Collaborator

@dpizetta dpizetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, need to run script/process_qrc.py to update files. If you could not run, I run here :)

Good job with this issue, but I can see the white corner in Linux Ubuntu yet. Ideas? Still some corner problems from #132

combobox-corners

My env:

* OPERATING SYSTEM----------------------------------------------------------------------------------------------
    - System........................ Linux
    - Release....................... 4.15.0-47-generic
    - Platform...................... Linux-4.15.0-47-generic-x86_64-with-debian-buster-sid
    - Version....................... #50-Ubuntu SMP Wed Mar 13 10:44:52 UTC 2019
* PYTHON DISTRIBUTION-------------------------------------------------------------------------------------------
    - Version....................... 3.6.8
    - C Compiler.................... GCC 7.3.0
    - C API Version................. 1013
    - Implementation................ cpython
    - Implementation Version........ 3.6.8
* CONDA DISTRIBUTION--------------------------------------------------------------------------------------------
    - Version....................... 4.6.12
    - Build......................... 3.17.8
* QT ABSTRACTIONS-----------------------------------------------------------------------------------------------
    - qtpy Version.................. 1.7.0
    - qtpy Binding.................. pyqt5
    - pyqtgraph Version............. 0.10.0
    - pyqtgraph Binding............. Not set or inexistent
    - Qt Version.................... 1.1.0
    - Qt Binding.................... PySide2
* QT BINDINGS---------------------------------------------------------------------------------------------------
    - PyQt5 Version................. 5.6
    - PyQt5 Qt Version.............. 5.6.2
    - PySide2 Version............... 5.12.2
    - PySide2 Qt Version............ 5.6.3

qdarkstyle/style.qss Outdated Show resolved Hide resolved
qdarkstyle/style.qss Outdated Show resolved Hide resolved
qdarkstyle/style.qss Outdated Show resolved Hide resolved
@goanpeca
Copy link
Collaborator Author

goanpeca commented Apr 30, 2019

Good job with this issue, but I can see the white corner in Linux Ubuntu yet. Ideas?

Nope, I tried it on a stand alone QComboBox example and it does not show so I am not sure what is causing it on Spyder.

Also not being able to refresh the stylesheets without having to restart the app makes this process painful :-| (spyder being a relatively heavy app)

@goanpeca
Copy link
Collaborator Author

Also, need to run script/process_qrc.py to update files. If you could not run, I run here :)

@dpizetta I would rather you run it for the moment, I do not have the whole toolchain installed. Thanks!

@dpizetta
Copy link
Collaborator

dpizetta commented May 1, 2019

No problems :) I do it soon.

@goanpeca
Copy link
Collaborator Author

goanpeca commented May 1, 2019

No problems :) I do it soon.

Awesome! thanks :-)

@dpizetta dpizetta merged commit c008e32 into ColinDuquesnoy:master May 1, 2019
@dpizetta dpizetta mentioned this pull request May 6, 2019
@goanpeca goanpeca deleted the fix/combobox branch July 5, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkboxes appear in QComboBox drop-down list
2 participants