Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add color palette and script to generate png images #142

Merged
merged 6 commits into from
May 4, 2019
Merged

PR: Add color palette and script to generate png images #142

merged 6 commits into from
May 4, 2019

Conversation

goanpeca
Copy link
Collaborator

Fixes #127
Fixes #140

  • Replaces extra SVG by a single SVG with a predefined color to be used for replacement (#ff0000)
  • Create script to create all pngs from the color palette
  • Adds high resolution pngs (See: https://doc.qt.io/qt-5/scalability.html)

@goanpeca
Copy link
Collaborator Author

@dpizetta I was not sure about which colors from the palette should be used, so please check this. Thanks!

@ColinDuquesnoy ColinDuquesnoy mentioned this pull request May 1, 2019
Merged
4 tasks
dpizetta
dpizetta requested changes May 1, 2019
View reviewed changes
Copy link
Collaborator

@dpizetta dpizetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nice to include the file palette.svg and .png into it, since they provide contrast tests for chosen colors what is really important. They are in the root directory. The colors seems to be correct for each file. Tks for this.

script/process_images.py Show resolved Hide resolved
qdarkstyle/qss/__init__.py Outdated Show resolved Hide resolved
@dpizetta dpizetta self-assigned this May 1, 2019
@dpizetta dpizetta added this to the 2.7 milestone May 1, 2019
@goanpeca
Copy link
Collaborator Author

goanpeca commented May 1, 2019

It is nice to include the file palette.svg and .png into it, since they provide contrast tests for chosen colors what is really important. They are in the root directory. The colors seems to be correct for each file. Tks for this.

Will add the change tomorrow

dpizetta added a commit that referenced this pull request May 1, 2019
@dpizetta
Update colors for png/svg and add @2x retina from intermediate #142, f…
8d26e03 
…ixes #127, #140
@goanpeca
Copy link
Collaborator Author

goanpeca commented May 3, 2019

@dpizetta made the changes as requested, now the palette is also generated :-)

@goanpeca
Copy link
Collaborator Author

goanpeca commented May 4, 2019

@dpizetta this one is ready!

@dpizetta dpizetta self-requested a review May 4, 2019 13:06
dpizetta
dpizetta requested changes May 4, 2019
View reviewed changes
Copy link
Collaborator

@dpizetta dpizetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goanpeca could you check init.py file to incorporate the new var added by your other commit? Tks

@goanpeca
Copy link
Collaborator Author

goanpeca commented May 4, 2019

Sure, will make it now

@goanpeca
Copy link
Collaborator Author

goanpeca commented May 4, 2019

@dpizetta ready :-p

@dpizetta dpizetta merged commit 6958bf7 into ColinDuquesnoy:master May 4, 2019
@dpizetta
Copy link
Collaborator

dpizetta commented May 4, 2019

Thank you @goanpeca!

@goanpeca goanpeca deleted the enh/svg-png branch July 5, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpizetta dpizetta dpizetta requested changes

Assignees

@dpizetta dpizetta

Labels
enhancement feature
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.

Add high resolution resources for retina displays QCheckBox and QRadioButton resource images colour
2 participants
@goanpeca @dpizetta