Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculator update #63

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Calculator update #63

merged 5 commits into from
Mar 21, 2024

Conversation

Gustavojfe
Copy link
Collaborator

this PR does 3 things:

  1. reduces the number of transaction queue length to 6, because Turbolay says this is closer to the current average real results.
  2. reduces the number of inputs and outputs to 9.
  3. inverts the order of the current fee rate box, with the is this your first coinjoin box, because the current fee rate is the only one with default values, and doesn't require user input.

this fixes the following issues:
#61
#60

this changes the transaction queue length to 6 when the privacy level is high, as Turbolay indicated that this reflects the current reality.
this reduces the number of max inputs and outputs per coinjoin transaction to 9
inverts order of box is this your first coinjoin and current fee rate
minimum is now 0 for numerical values, and the step for bitcoin amount is 0.00000001 to allow for satoshis
@Gustavojfe
Copy link
Collaborator Author

my last commit also should fix this issue

#58

@thibistaken
Copy link
Collaborator

Formatting on the input is off image

@thibistaken
Copy link
Collaborator

I added one commit to fix the scientific notation issue highlighted above for the btc amount input, and to allow custom fee rate user input to overwrite the default mempool.space value.

Copy link
Collaborator

@thibistaken thibistaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@thibistaken thibistaken merged commit b41b7a1 into main Mar 21, 2024
@thibistaken thibistaken deleted the calculator-update branch March 21, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants