Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joinstr page #56

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Fix joinstr page #56

merged 3 commits into from
Mar 22, 2024

Conversation

1440000bytes
Copy link
Contributor

Made changes in 2 points

@1440000bytes
Copy link
Contributor Author

image

I think it should just be "joinstr" and "nostr" should be removed. Not sure what should be changed in the JSON:

{
  "title": "Coinjoins.org - Joinstr Review",
  "wallet_name": "Joinstr",
  "protocol_name": "Nostr",
  "wallet_logo": "joinstr",

There is no joinstr wallet. Joinstr is a protocol so maybe wallet_name can be removed?

@Gustavojfe
Copy link
Collaborator

@thibistaken could we tweak the code so the joinstr page doesn't need both a wallet name and a protocol name, so it can only be Joinstr (without Nostr)?

@thibistaken thibistaken merged commit ecf1cd7 into CoinjoinsOrg:main Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants