[DO NOT MERGE] Feat/google maps flutter ground overlay support #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: google_maps_flutter
platform-android
platform-ios
platform-web
labels
jokerttu
force-pushed
the
feat/google_maps_flutter_ground_overlay_support
branch
from
db7e48b to
b04e31f
Compare
jokerttu
force-pushed
the
feat/google_maps_flutter_ground_overlay_support
branch
2 times, most recently
from
316f241 to
0d259ee
Compare
aednlaxer
reviewed
Jan 10, 2025
...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java
Outdated
Show resolved
Hide resolved
...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java
Outdated
Show resolved
Hide resolved
...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java
Outdated
Show resolved
Hide resolved
...aps_flutter/google_maps_flutter_ios/example/shared/maps_example_dart/lib/ground_overlay.dart
Outdated
Show resolved
Hide resolved
...aps_flutter/google_maps_flutter_ios/example/shared/maps_example_dart/lib/ground_overlay.dart
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_web/lib/src/ground_overlays.dart
Outdated
Show resolved
Hide resolved
Comment on lines
101
to
102
| /// Returns the [GroundOverlay] with the given [GroundOverlayId] for testing | ||
| /// purposes. |
There was a problem hiding this comment.
I wonder if "for testing purposes" could be used along with the @visibleForTesting annotation?
There was a problem hiding this comment.
Yes, it would be nice, but this is used in GoogleMapsInspectorWeb which is not test file... even when it is meant to be used as testing support class only.
causing following linting error:
The member 'getGroundOverlay' can only be used within 'package:google_maps_flutter_web/src/ground_overlays.dart' or a test.dart[invalid_use_of_visible_for_testing_member](https://dart.dev/diagnostics/invalid_use_of_visible_for_testing_member)
packages/google_maps_flutter/google_maps_flutter/example/lib/ground_overlay.dart
Outdated
Show resolved
Hide resolved
...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart
Outdated
Show resolved
Hide resolved
...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart
Outdated
Show resolved
Hide resolved
|
Thanks, @aednlaxer! |
* test: add initial ios integration tests * fix integration tests for iOS * fix: add zoom level assert to ios groundoverlays * test: ios ground overlay unit tests * test: refactor integration tests * refactor: pr fixes and refactoring --------- Co-authored-by: Joonas Kerttula <[email protected]>
add assert if bitmapScaling is not MapBitmapScaling.none
…id/src/main/java/io/flutter/plugins/googlemaps/Convert.java Co-authored-by: Alexander Troshkov <[email protected]>
…rc/google_maps_flutter_android.dart Co-authored-by: Alexander Troshkov <[email protected]>
…rc/google_maps_flutter_android.dart Co-authored-by: Alexander Troshkov <[email protected]>
jokerttu
force-pushed
the
feat/google_maps_flutter_ground_overlay_support
branch
from
2edb03a to
6c72f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.