feat: add initial integration tests for ground overlays #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: google_maps_flutter
platform-android
platform-ios
platform-web
labels
| /// | [GroundOverlay.width] | Yes (for position only) | No | No | | ||
| /// | [GroundOverlay.height] | Yes (for position only) | No | No | | ||
| /// | [GroundOverlay.anchor] | Yes (for position only) | Yes | No | | ||
| /// | [GroundOverlay.zoomLevel] | No | Yes | No | |
There was a problem hiding this comment.
Should we put here (for position only) also for zoomLevel and iOS?
There was a problem hiding this comment.
yes. let's merge this and you can update the iOS side, as I am not sure about other methods either
jokerttu
merged commit ef71871
into
feat/google_maps_flutter_ground_overlay_support
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration tests for app facing package and android