Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: updated code snippets #3034

Merged
merged 2 commits into from
Feb 10, 2025
Merged

docs: updated code snippets #3034

merged 2 commits into from
Feb 10, 2025

Conversation

LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Feb 7, 2025 •
edited
Loading

Overview

Updated VSCode snippets to set whitespacing consistencies and updated some other fields.

PR Checklist

  • Related to JIRA ticket: GM-967
  • I have run this code to verify it works

Testing Instructions

  1. Pull the branch down locally.
  2. In a file, preferably a new blank one, try out the commands:
  3. component-doc, check for that the template fields are correct and whitespaces look good
  4. toc-story, check for that the template fields are correct and whitespaces look good
  5. ...
  6. Profit!

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 7, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b009da7.

☁️ Nx Cloud last updated this comment at 2025-02-10 15:19:32 UTC

@LinKCoding LinKCoding marked this pull request as ready for review February 7, 2025 19:25
@LinKCoding LinKCoding requested a review from a team as a code owner February 7, 2025 19:25
@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://67aa1951e493bd4b3cb2ffff--gamut-preview.netlify.app

Deploy Logs

aresnik11
aresnik11 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok how did I not know this existed!!! Changes LGTM

@LinKCoding LinKCoding added the Ship It :shipit: Automerge this PR when possible label Feb 10, 2025
@codecademydev codecademydev merged commit 973ae7f into main Feb 10, 2025
20 of 21 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Feb 10, 2025
@codecademydev codecademydev deleted the kl-gm-967 branch February 10, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aresnik11 aresnik11 aresnik11 approved these changes

@dreamwasp dreamwasp Awaiting requested review from dreamwasp dreamwasp is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LinKCoding @codecademydev @aresnik11