chore: remove reach/auto-id #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 47245f9. ☁️ Nx Cloud last updated this comment at |
jakemhiller
reviewed
Feb 6, 2025
packages/gamut/package.json
Outdated
| @@ -9,7 +9,6 @@ | |||
| "@codecademy/gamut-patterns": "0.10.3", | |||
| "@codecademy/gamut-styles": "17.4.1", | |||
| "@codecademy/variance": "0.22.1", | |||
| "@reach/auto-id": "^0.16.0", | |||
| "@reach/tabs": "^0.16.4", | |||
There was a problem hiding this comment.
hm, i know it hasn't been updated in a while but we should still get on the latest version before we replace this. I think @timjenkins was working on that a while ago, maybe someone can take it over the finish line
There was a problem hiding this comment.
good eye - i'll see if i can update the tabs in this PR easily. i think we still delete auto-id since it's identical to React's useId
aresnik11
approved these changes
Feb 10, 2025
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes reach/id from the repository and replace with React's useId and upgrade @reach/tabs
PR Checklist
Testing Instructions
Everything should work as usual
PR Links and Envs