Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump prettier packages + fix format push #3025

Merged
merged 11 commits into from
Feb 5, 2025
Merged

chore: bump prettier packages + fix format push #3025

merged 11 commits into from
Feb 5, 2025

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Feb 3, 2025 •
edited by jira bot
Loading

Overview

Fixes yarn format not running on PR preview, updates prettier to the version on the monorepo

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GM-989
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Head to the Storybook preview
  2. Click around and see nothing's broken
  3. Head to the mono preview eng
  4. See nothing is broken
  5. Head to the monolith preview env
  6. See nothing is broken
  7. Check out the yarn format check failing correctly here

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 036746a.

☁️ Nx Cloud last updated this comment at 2025-02-05 15:57:10 UTC

@dreamwasp dreamwasp changed the title bump packages + fix format push chore: bump prettier packages + fix format push Feb 4, 2025
@dreamwasp dreamwasp marked this pull request as ready for review February 4, 2025 19:46
@dreamwasp dreamwasp requested a review from a team as a code owner February 4, 2025 19:46
LinKCoding
LinKCoding approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Neat ✨

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://67a38a1d12c90f62c9cc2f18--gamut-preview.netlify.app

Deploy Logs

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Feb 5, 2025
@codecademydev codecademydev merged commit fda3278 into main Feb 5, 2025
17 of 18 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Feb 5, 2025
@codecademydev codecademydev deleted the cass-gm-989 branch February 5, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinKCoding LinKCoding LinKCoding approved these changes

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamwasp @codecademydev @LinKCoding