feat(Video): Adds Accessible Video Component #3015
Conversation
…nto sg-vidstack-poc
|
View your CI Pipeline Execution ↗ for commit db1e343. ☁️ Nx Cloud last updated this comment at |
…mut into sg-3436-video-player
…eo and iframe overides of markdown
smithgajjar09
changed the title
smithgajjar09
changed the title
packages/gamut/src/Video/index.tsx
Outdated
| /** | ||
| * If showPlayerEmbed is true and Video Url is a string, use ReactPlayer to render the video | ||
| * Otherwise, use the Vidstack MediaPlayer. This is because currently vidstack player has an issue with | ||
| * youtube iframe embeds where it keeps pausing (only in case if yt iframe is used i.e with native yt controls) | ||
| */ |
There was a problem hiding this comment.
is this recorded anywhere in Vidstack's backlog? most of our Codecademy content is from YT and i'm not a huge fan of keeping both media players/supporting both if we don't have to
There was a problem hiding this comment.
There was a mention about this issue in Vidstack but not sure if there are actively looking into this issue yet. But after pooking around for a bit was able to add a workaround fix due to recent update in vidstack. We still have showPlayerEmbed flag to render ReactPlayer just as a fallback until we validate this player in the app. Adding a backlog ticket to remove
There was a problem hiding this comment.
swee, that sounds good to me and we can talk to reed about the effort to move our Codecademy videos away from YT. can you link the backlog ticket # here and add to this epic ?
There was a problem hiding this comment.
yes, here's the ticket - GM-998
…mut into sg-3436-video-player
…mut into sg-3436-video-player
There was a problem hiding this comment.
looks good to me! I think it's worth getting @dreamwasp's final review before merging.
packages/gamut/src/Video/index.tsx
Outdated
| /** | ||
| * If showPlayerEmbed is true use ReactPlayer to render the video | ||
| * Otherwise, use the Vidstack MediaPlayer. @TEMPORARY_FALLBACK | ||
| */ |
There was a problem hiding this comment.
This is more of just a fallback in case something goes sideways, and also when released all the youtube videos will be rendered using this new player (which does not have auto generated captions) So if curriculum asks to switch it to embed we have some way to make sure everything works
We have a follow up ticket to remove ReactPlayer once everything is validated - GM-998
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
Overview
adds a new video component with Vidstack integration that is accessible with HLS support including captions, thumbnails, chapters and poster addon.
PR Checklist
Testing Instructions
PR Links and Envs
Notes