-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BorderRadius token)!: Adding a border radius scale #2918
Conversation
packages/gamut/src/Card/index.tsx
Outdated
@@ -109,6 +109,7 @@ export const Card: React.FC<CardProps> = ({ variant, ...rest }) => { | |||
<DynamicCardWrapper | |||
border={1} | |||
borderColor="secondary-hover" | |||
borderRadius="m" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this in b.c. for shadow variants, the border-radius resets to 0
border-radius: 4px; | ||
overflow: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rounds out the corners for a video player, however since it's using .scss it doesn't use tokens
* updated atom's border radius
* updated molecules + organism borderradii
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks great to me! just pending approval until the integration PRs are sorted
📬Published Alpha Packages:@codecademy/[email protected] |
🚀 Styleguide deploy preview ready! |
Overview
Adding a border radius token (
borderRadii
) into gamut. There will now be standardized border radii - wherenone
is0px
,sm
is2px
,md
is4px
,lg
is8px
,xl
is16px
, andfull
is50%
.This also addresses some components which had outdated borderRadii.
There are also other test branches:
PR Checklist
Testing Instructions
Alert 3 -> 2 (small)
Button, CTA 2 -> 4 (medium)
Card 0 -> 4 (medium) *
Disclosure 0 -> 4 (medium)
Drawer 0 -> 2 (small)
Floating Card 2 -> 0 (none)
FormInputs:
Checkbox 0 -> 4 (medium)
Input 2 -> 4 (medium)
Select Dropdown 2 -> 4 (medium)**
Text Area 2 -> 4 (medium)**
Modal/dialog 0 -> 2 (small)
Tip 3 -> 2 (small)
Notes:
** the selectdropdown and textarea (from what I can tell, was 0 in prod, prior to change), though selectdropdown did have a 2px border radius for formatGroupLabel (so I added change it from 2px => 4 in this case too, since it seemed like all input-related elements were being updated to 4)
PR Links and Envs