Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Icons): add new icons for community event cards #2863

Merged
merged 3 commits into from
Apr 16, 2024
Merged

feat(Icons): add new icons for community event cards #2863

merged 3 commits into from
Apr 16, 2024

Conversation

natalieweesh
Copy link
Contributor

@natalieweesh natalieweesh commented Apr 16, 2024 •
edited
Loading

Overview

add new icons for community events cards
and update EventsIllustration

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@natalieweesh natalieweesh requested a review from a team as a code owner April 16, 2024 17:28
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://661eb80b7b10265528002817--gamut-preview.netlify.app

Deploy Logs

LinKCoding
LinKCoding approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@natalieweesh natalieweesh added the Ship It :shipit: Automerge this PR when possible label Apr 16, 2024
@codecademydev codecademydev merged commit eda79b9 into main Apr 16, 2024
19 of 20 checks passed
@codecademydev codecademydev deleted the nw-events-cards-icons branch April 16, 2024 19:12
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinKCoding LinKCoding LinKCoding approved these changes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natalieweesh @codecademydev @LinKCoding