Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(List): add overflow prop #2850

Merged
merged 10 commits into from
Apr 4, 2024
Merged

feat(List): add overflow prop #2850

merged 10 commits into from
Apr 4, 2024

Conversation

smithgajjar09
Copy link
Contributor

@smithgajjar09 smithgajjar09 commented Mar 18, 2024 •
edited
Loading

Overview

Adds an overflow prop to List Component

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [GM-636]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. visit courses/introduction-to-javascript/quizzes/learn-javascript-control-flow-control-flow-quiz
  2. tab through the quiz MCQ options, focus-rings should be visible.

PR Links and Envs

Repository PR Link PR Env
LE (le-shared) Mono LE Env
Portal App Mono LE Env

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@smithgajjar09 smithgajjar09 marked this pull request as ready for review March 19, 2024 11:44
@smithgajjar09 smithgajjar09 requested a review from a team as a code owner March 19, 2024 11:44
dreamwasp
dreamwasp approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really wonderful change, i love how intuitive this + great docs changes as well! really matches the spirit of Gamut 🔥

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://660ecb3c153a6216114e5c68--gamut-preview.netlify.app

Deploy Logs

@smithgajjar09 smithgajjar09 added the Ship It :shipit: Automerge this PR when possible label Apr 4, 2024
@codecademydev codecademydev merged commit 2ebd754 into main Apr 4, 2024
18 of 19 checks passed
@codecademydev codecademydev deleted the sg-list-overflow-fix branch April 4, 2024 16:27
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smithgajjar09 @CLAassistant @codecademydev @dreamwasp