Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Icons): add TikTokIcon #2845

Merged
merged 1 commit into from
Mar 11, 2024
Merged

feat(Icons): add TikTokIcon #2845

merged 1 commit into from
Mar 11, 2024

Conversation

bndiep
Copy link
Contributor

@bndiep bndiep commented Mar 8, 2024 •
edited
Loading

Overview

Adds TikTokIcon

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: DOT-75
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Use the Storybook preview to view the new icons
  2. The TikTokIcon will be under "Vendor Icons". Ensure the icon look good in the preview.
Screenshot 2024-03-08 at 10 29 32 AM

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://65eb584f6e8185d072799fa8--gamut-preview.netlify.app

Deploy Logs

@bndiep bndiep marked this pull request as ready for review March 11, 2024 15:45
@bndiep bndiep requested a review from a team as a code owner March 11, 2024 15:45
@bndiep bndiep requested review from timjenkins and aresnik11 March 11, 2024 15:45
dreamwasp
dreamwasp approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@bndiep bndiep added the Ship It :shipit: Automerge this PR when possible label Mar 11, 2024
@codecademydev codecademydev merged commit fc5a378 into main Mar 11, 2024
35 of 37 checks passed
@codecademydev codecademydev deleted the bd.add-tiktok-icon branch March 11, 2024 16:01
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins is a code owner automatically assigned from Codecademy/gamut

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bndiep @codecademydev @dreamwasp