feat(ProgressBar): adds flat prop to progressBar #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sooinc
changed the title
sooinc
changed the title
sooinc
requested review from
jakemhiller,
timjenkins,
aionate0812 and
sylvanasantos
sylvanasantos
requested changes
Mar 14, 2024
ah oops, thanks for catching! i just adjusted it. |
sylvanasantos
approved these changes
Mar 14, 2024
.vscode/settings.json
Outdated
| @@ -37,7 +37,7 @@ | |||
| }, | |||
| "typescript.tsdk": "node_modules/typescript/lib", | |||
| "editor.codeActionsOnSave": { | |||
| "source.fixAll.eslint": true | |||
| "source.fixAll.eslint": "explicit" | |||
There was a problem hiding this comment.
Is this an intended change? Also is this because imports haven't been automatically sorting when you save a file on vscode? Because same lol
There was a problem hiding this comment.
oh no, for some reason this keeps getting updated. i reverted as i didnt mean to push!
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
flatprop to ProgresseBarPR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs