Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NotificationList): move to NotificationsList to Brand #2838

Merged
merged 10 commits into from
Feb 29, 2024
Merged

chore(NotificationList): move to NotificationsList to Brand #2838

merged 10 commits into from
Feb 29, 2024

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Feb 26, 2024 •
edited
Loading

Overview

Moves the NotificationList and its related types to Brand

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Head to the monolith or monorepo PRs and check out the notifcationlists ✨

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Monorepo Portal Link Portal Env

@dreamwasp dreamwasp marked this pull request as ready for review February 27, 2024 18:11
@dreamwasp dreamwasp requested a review from a team as a code owner February 27, 2024 18:11
jakemhiller
jakemhiller approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. seems like there is a formatting issue on an unrelated button file though

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Feb 28, 2024
BandanaKM
BandanaKM approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@BandanaKM BandanaKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, cass 💯

@dreamwasp dreamwasp added Ship It :shipit: Automerge this PR when possible and removed Ship It :shipit: Automerge this PR when possible labels Feb 29, 2024
@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://65e09e34652c8c0b50d21550--gamut-preview.netlify.app

Deploy Logs

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev codecademydev merged commit d2c8019 into main Feb 29, 2024
8 of 11 checks passed
@codecademydev codecademydev deleted the cass-gm-626 branch February 29, 2024 15:28
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@BandanaKM BandanaKM BandanaKM approved these changes

@aresnik11 aresnik11 aresnik11 approved these changes

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins is a code owner automatically assigned from Codecademy/gamut

@LinKCoding LinKCoding Awaiting requested review from LinKCoding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dreamwasp @codecademydev @jakemhiller @BandanaKM @aresnik11