Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Alert): href error #2831

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix(Alert): href error #2831

merged 1 commit into from
Feb 7, 2024

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Feb 7, 2024 •
edited
Loading

Overview

fixes Alert types for href

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

No type errors here

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://65c3f7d2db59470436ccab6d--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp requested a review from aresnik11 February 7, 2024 21:37
@dreamwasp dreamwasp marked this pull request as ready for review February 7, 2024 21:37
@dreamwasp dreamwasp requested a review from a team as a code owner February 7, 2024 21:37
@dreamwasp dreamwasp requested a review from BandanaKM February 7, 2024 21:37
@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Feb 7, 2024
@codecademydev codecademydev merged commit 93ee979 into main Feb 7, 2024
23 of 25 checks passed
@codecademydev codecademydev deleted the cass-web-1833-fix branch February 7, 2024 22:01
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aresnik11 aresnik11 aresnik11 approved these changes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamwasp @codecademydev @aresnik11